web/src/pages/projects/index.tsx (1)

44-60: 排序实现正确，有小幅优化空间。

当前实现正确使用 slice() 避免原数组变异，Number.isFinite 检查也妥善处理了无效日期。不过在比较函数中重复创建 Date 对象可以优化：

♻️ 可选优化：预先计算时间戳

 const sortedProjects = useMemo(() => {
   if (!projects) {
     return undefined;
   }
-  return projects.slice().sort((a, b) => {
-    const timeA = Number.isFinite(new Date(a.createdAt).getTime())
-      ? new Date(a.createdAt).getTime()
-      : 0;
-    const timeB = Number.isFinite(new Date(b.createdAt).getTime())
-      ? new Date(b.createdAt).getTime()
-      : 0;
-    if (timeA !== timeB) {
-      return timeA - timeB;
-    }
-    return a.id - b.id;
-  });
+  return projects
+    .map((p) => {
+      const time = new Date(p.createdAt).getTime();
+      return { ...p, _sortTime: Number.isFinite(time) ? time : 0 };
+    })
+    .sort((a, b) => {
+      if (a._sortTime !== b._sortTime) {
+        return a._sortTime - b._sortTime;
+      }
+      return a.id - b.id;
+    });
 }, [projects]);

对于常规项目列表规模，当前实现性能影响可忽略不计。

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/src/pages/projects/index.tsx` around lines 44 - 60, The sort comparator
recreates Date objects twice per item; optimize by precomputing numeric
timestamps before sorting: inside the useMemo that defines sortedProjects, map
projects to temporary objects (or use a memoized map) that attach a parsed
timestamp for each item's createdAt (e.g., computedTimestamp), then sort using
those computed timestamps and fall back to id when equal; update references to
timeA/timeB to use the precomputed timestamp field so Date() is not constructed
repeatedly in the comparator.

web/src/locales/zh.json (1)

1085-1087: 文件末尾存在多余空行。

建议移除多余的空行，保持 JSON 文件格式一致性。

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/src/locales/zh.json` around lines 1085 - 1087, 文件 web/src/locales/zh.json
在末尾包含多余空行：打开 zh.json（注意检查文件尾部），删除多余的空白/空行以确保文件末尾不包含空行并保持有效的 JSON
语法，保存时确保只保留一个必要的换行或无多余空白字符以符合项目格式约定。

cmd/maxx/main.go (1)

472-475: 不可达代码

os.Exit(0) 之后的 return nil 永远不会执行。虽然不影响功能，但属于死代码。

♻️ 建议移除

   log.Printf("[Admin] Started new process (pid=%d). Exiting current process.", cmd.Process.Pid)
   os.Exit(0)
-  return nil
+  return nil // unreachable, but satisfies return type
 }

或者添加注释说明这是为了满足返回类型要求。

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmd/maxx/main.go` around lines 472 - 475, The line "return nil" after
os.Exit(0) in the main.go path is unreachable dead code; remove the unreachable
return or, if you prefer to keep it for readability/compile reasons, replace it
with a clear comment explaining it's intentionally unreachable (e.g., after the
os.Exit call in the block that logs "[Admin] Started new process (pid=%d).
Exiting current process."); update the code around cmd.Process.Pid and os.Exit
to either omit the return or add the explanatory comment so no dead code
remains.

web/src/components/layout/app-sidebar/nav-user.tsx (3)

226-232: 不必要的空 React Fragment

<>...</> 在这里作为 DropdownMenuContent 的直接子元素是多余的，可以直接放置 DropdownMenuSeparator 和 DropdownMenuItem。

♻️ 建议简化

             </DropdownMenuGroup>
-            <>
-              <DropdownMenuSeparator />
-              <DropdownMenuItem onClick={handleRestartServer}>
-                <RefreshCw />
-                <span>{t('nav.restartServer')}</span>
-              </DropdownMenuItem>
-            </>
+            <DropdownMenuSeparator />
+            <DropdownMenuItem onClick={handleRestartServer}>
+              <RefreshCw />
+              <span>{t('nav.restartServer')}</span>
+            </DropdownMenuItem>
           </DropdownMenuContent>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/src/components/layout/app-sidebar/nav-user.tsx` around lines 226 - 232,
当前在 DropdownMenuContent 的直接子节点中使用了多余的空 React Fragment (<>...</>); 请移除该片段并将
DropdownMenuSeparator 和 DropdownMenuItem (带 onClick={handleRestartServer} 和
RefreshCw 图标及 t('nav.restartServer') 文本) 直接作为子元素放置，确保不改变现有 props 或事件处理器（例如
handleRestartServer）的绑定。

---

42-45: 桌面端重启检测逻辑重复类型断言

desktopRestartAvailable 变量的类型断言在使用时又重复了一次（Lines 55-57）。建议提取为一个复用的类型定义或工具函数，以减少代码重复和潜在的类型不一致风险。

♻️ 建议优化

+type DesktopLauncher = {
+  go?: { desktop?: { LauncherApp?: { RestartServer?: () => Promise<void> } } };
+};
+
+const getDesktopLauncher = () =>
+  (window as unknown as DesktopLauncher).go?.desktop?.LauncherApp;
+
 const desktopRestartAvailable =
-  typeof window !== 'undefined' &&
-  !!(window as unknown as { go?: { desktop?: { LauncherApp?: { RestartServer?: () => unknown } } } })
-    .go?.desktop?.LauncherApp?.RestartServer;
+  typeof window !== 'undefined' && !!getDesktopLauncher()?.RestartServer;

 const handleRestartServer = async () => {
   if (!window.confirm(t('nav.restartServerConfirm'))) return;
   try {
     if (desktopRestartAvailable) {
-      const launcher = (window as unknown as {
-        go?: { desktop?: { LauncherApp?: { RestartServer?: () => Promise<void> } } };
-      }).go?.desktop?.LauncherApp;
+      const launcher = getDesktopLauncher();
       if (!launcher?.RestartServer) {
         throw new Error('Desktop restart is unavailable.');
       }

Also applies to: 54-62

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/src/components/layout/app-sidebar/nav-user.tsx` around lines 42 - 45, The
repeated complex type assertion around
window.go.desktop.LauncherApp.RestartServer (used when computing
desktopRestartAvailable and again at lines 55-57) should be replaced by a single
reusable type or helper to avoid duplication; create a narrow type alias or
utility function (e.g., isDesktopRestartAvailable or a WindowWithLauncherApp
type) that encapsulates the cast and existence check for RestartServer and use
that helper wherever desktop restart availability is tested (references:
desktopRestartAvailable, RestartServer, go.desktop.LauncherApp).

---

65-70: 冗余的 typeof window 检查

在 'use client' 组件中，window 对象始终存在，Line 67 的检查是多余的。

♻️ 建议简化

   } catch (error) {
     console.error('Restart server failed:', error);
-    if (typeof window !== 'undefined') {
-      window.alert(t('nav.restartServerFailed'));
-    }
+    window.alert(t('nav.restartServerFailed'));
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/src/components/layout/app-sidebar/nav-user.tsx` around lines 65 - 70, The
catch block in nav-user.tsx redundantly checks typeof window inside this 'use
client' component; remove the unnecessary guard and call window.alert directly
(inside the catch where console.error('Restart server failed:', error) is
called) so the code uses window.alert(t('nav.restartServerFailed')) without the
typeof window check.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

cmd/maxx/main.go (1)

451-475: ⚠️ Potential issue | 🟠 Major

重启失败时服务器无法恢复的问题仍然存在

当前代码在调用 shutdownServer 之后才尝试获取可执行文件路径和启动新进程。如果 os.Executable() 或 cmd.Start() 失败，服务器已经关闭且无法恢复。

建议在关闭服务器之前先验证可执行文件是否可访问。

🛠️ 建议的修复方案

 restartServer := func() error {
   if !atomic.CompareAndSwapInt32(&restartInProgress, 0, 1) {
     return fmt.Errorf("restart already in progress")
   }

-  shutdownServer("restart")
-
   executable, err := os.Executable()
   if err != nil {
+    atomic.StoreInt32(&restartInProgress, 0)
     return fmt.Errorf("failed to locate executable: %w", err)
   }

+  // 在关闭前验证可执行文件可访问
+  if _, err := os.Stat(executable); err != nil {
+    atomic.StoreInt32(&restartInProgress, 0)
+    return fmt.Errorf("executable not accessible: %w", err)
+  }
+
+  shutdownServer("restart")
+
   cmd := exec.Command(executable, os.Args[1:]...)
   cmd.Stdout = os.Stdout
   cmd.Stderr = os.Stderr
   cmd.Env = os.Environ()

   if err := cmd.Start(); err != nil {
+    // 此时 shutdown 已执行，记录严重错误
+    log.Printf("[Admin] CRITICAL: Failed to start new process after shutdown: %v", err)
     return fmt.Errorf("failed to start new process: %w", err)
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmd/maxx/main.go` around lines 451 - 475, The restartServer closure currently
calls shutdownServer("restart") before confirming that os.Executable() and
starting the new process (exec.Command + cmd.Start()) succeed; if those fail the
server is down with restartInProgress set. Change restartServer so it first
obtains and validates the executable path (os.Executable), constructs the
exec.Command (os.Args[1:], os.Environ()), and attempts to start the new process
(cmd.Start()) — only after cmd.Start() succeeds should shutdownServer("restart")
be invoked and os.Exit called; on any failure, ensure restartInProgress is reset
(atomic.StoreInt32(&restartInProgress, 0)) and return the error. Ensure you
reference the same symbols: restartServer, restartInProgress, shutdownServer,
os.Executable, exec.Command, and cmd.Start.

web/src/components/layout/app-sidebar/nav-user.tsx (2)

42-45: 类型断言重复定义

desktopRestartAvailable 的类型断言（Lines 42-45）和 handleRestartServer 内部的类型断言（Lines 55-57）略有不同：前者返回 unknown，后者返回 Promise<void>。建议统一类型定义以提高可维护性。

♻️ 建议的重构方案

+type DesktopLauncher = {
+  go?: { desktop?: { LauncherApp?: { RestartServer?: () => Promise<void> } } };
+};

 const desktopRestartAvailable =
   typeof window !== 'undefined' &&
-  !!(window as unknown as { go?: { desktop?: { LauncherApp?: { RestartServer?: () => unknown } } } })
+  !!(window as unknown as DesktopLauncher)
     .go?.desktop?.LauncherApp?.RestartServer;

 const handleRestartServer = async () => {
   if (!window.confirm(t('nav.restartServerConfirm'))) return;
   try {
     if (desktopRestartAvailable) {
-      const launcher = (window as unknown as {
-        go?: { desktop?: { LauncherApp?: { RestartServer?: () => Promise<void> } } };
-      }).go?.desktop?.LauncherApp;
+      const launcher = (window as unknown as DesktopLauncher).go?.desktop?.LauncherApp;

Also applies to: 54-57

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/src/components/layout/app-sidebar/nav-user.tsx` around lines 42 - 45, The
two type assertions are inconsistent: unify the signature used for the
LauncherApp.RestartServer across desktopRestartAvailable and handleRestartServer
by introducing a single shared type/interface (e.g., an extended Window type or
LauncherApp interface) where go.desktop.LauncherApp.RestartServer is declared as
() => Promise<void>, then replace both inline casts with that shared type (use
it in the desktopRestartAvailable check and the call site in
handleRestartServer) so the type is consistent and maintainable.

---

226-232: Fragment 包装器可移除

此处的空 Fragment (<>...</>) 包裹 DropdownMenuSeparator 和 DropdownMenuItem 是多余的，因为它们可以直接作为 DropdownMenuContent 的子元素。

♻️ 建议的简化方案

-            <>
-              <DropdownMenuSeparator />
-              <DropdownMenuItem onClick={handleRestartServer}>
-                <RefreshCw />
-                <span>{t('nav.restartServer')}</span>
-              </DropdownMenuItem>
-            </>
+            <DropdownMenuSeparator />
+            <DropdownMenuItem onClick={handleRestartServer}>
+              <RefreshCw />
+              <span>{t('nav.restartServer')}</span>
+            </DropdownMenuItem>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/src/components/layout/app-sidebar/nav-user.tsx` around lines 226 - 232,
当前在 DropdownMenuContent 内使用了多余的空 Fragment 包裹 DropdownMenuSeparator 和
DropdownMenuItem（包含 handleRestartServer 调用），请直接移除该 Fragment，使
DropdownMenuSeparator 和 DropdownMenuItem 成为 DropdownMenuContent 的直接子元素（保留
RefreshCw 图标和 handleRestartServer 处理器及翻译键 t('nav.restartServer') 不变）。

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro